Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky pubsub test #3780

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: flaky pubsub test #3780

merged 1 commit into from
Dec 18, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Dec 16, 2024 •
edited
Loading

  • Integration test was failing because a consumer group may not have set its offsets to the latest before events started getting published
    • For now I'll treat this as a known issue and just add a delay in the test.
  • Logging is now more consistent
  • Removed unused test module

@matt2e matt2e force-pushed the matt2e/pubsub/fix-flaky-test branch 2 times, most recently from 5ba487e to cfb0a08 Compare December 16, 2024 06:10
@alecthomas alecthomas mentioned this pull request Dec 16, 2024
Open
@matt2e matt2e force-pushed the matt2e/pubsub/fix-flaky-test branch 8 times, most recently from ba2a87a to ca24881 Compare December 18, 2024 00:19
@matt2e matt2e force-pushed the matt2e/pubsub/fix-flaky-test branch from ca24881 to 315c32c Compare December 18, 2024 02:22
@matt2e matt2e marked this pull request as ready for review December 18, 2024 02:24
@matt2e matt2e requested a review from alecthomas as a code owner December 18, 2024 02:24
@matt2e matt2e enabled auto-merge (squash) December 18, 2024 02:24
@matt2e matt2e merged commit 07b96de into main Dec 18, 2024
91 checks passed
@matt2e matt2e deleted the matt2e/pubsub/fix-flaky-test branch December 18, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matt2e